This is an archive of the discontinued LLVM Phabricator instance.

clang-cl: Accept (and ignore) /Zc:__cplusplus.
ClosedPublic

Authored by thakis on Apr 20 2018, 6:11 AM.

Details

Reviewers
hans
Summary

See https://blogs.msdn.microsoft.com/vcblog/2018/04/09/msvc-now-correctly-reports-__cplusplus/

clang-cl already sets __cplusplus to the correct value, so we can just ignore this flag.

Also add test coverage for a few more accepted-but-ignored flags.

Diff Detail

Event Timeline

thakis created this revision.Apr 20 2018, 6:11 AM
thakis edited the summary of this revision. (Show Details)
hans accepted this revision.Apr 20 2018, 6:13 AM

lgtm, thanks!

This revision is now accepted and ready to land.Apr 20 2018, 6:13 AM
thakis closed this revision.Apr 20 2018, 6:14 AM

r330427, thanks!