This is an archive of the discontinued LLVM Phabricator instance.

Differential D45811

[Unittests] Fix plugins test
ClosedPublic

Authored by miyuki on Apr 19 2018, 5:45 AM.

Details

Reviewers
philip.pfaffe
Commits
rGaeb6c48d2937: [Unittests] Fix plugins test
rL330329: [Unittests] Fix plugins test
Summary

Currently the PluginsTests.LoadPlugin unit test is failing in
LLVM configurations that have LLVM_EXPORT_SYMBOLS_FOR_PLUGINS enabled
because the EnableABIBreakingChecks symbol is missing.

This patch fixes the issue by linking some additional libraries to the
test plugin if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is enabled.

Diff Detail

Event Timeline

miyuki created this revision.Apr 19 2018, 5:45 AM
Herald added a subscriber: mgorny. · View Herald TranscriptApr 19 2018, 5:45 AM
philip.pfaffe accepted this revision.Apr 19 2018, 6:35 AM

LGTM, and solves the issue locally.

Thanks for fixing!

This revision is now accepted and ready to land.Apr 19 2018, 6:35 AM
Closed by commit rL330329: [Unittests] Fix plugins test (authored by miyuki). · Explain WhyApr 19 2018, 7:06 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
unittests/
Passes/
2 lines

Diff 143076

unittests/Passes/CMakeLists.txt

Show All 10 Lines set_output_directory(TestPlugin
LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR} LIBRARY_DIR ${CMAKE_CURRENT_BINARY_DIR}/${CMAKE_CFG_INTDIR}
) )
set_target_properties(TestPlugin set_target_properties(TestPlugin
PROPERTIES PREFIX "" PROPERTIES PREFIX ""
SUFFIX ".so" SUFFIX ".so"
) )
if (WIN32 OR CYGWIN) if (WIN32 OR CYGWIN OR LLVM_EXPORT_SYMBOLS_FOR_PLUGINS)
llvm_map_components_to_libnames(LLVM_DEPS ${LLVM_LINK_COMPONENTS}) llvm_map_components_to_libnames(LLVM_DEPS ${LLVM_LINK_COMPONENTS})
target_link_libraries(TestPlugin ${LLVM_DEPS}) target_link_libraries(TestPlugin ${LLVM_DEPS})
endif() endif()
add_dependencies(TestPlugin intrinsics_gen) add_dependencies(TestPlugin intrinsics_gen)
add_dependencies(PluginsTests TestPlugin) add_dependencies(PluginsTests TestPlugin)
endif() endif()