This is an archive of the discontinued LLVM Phabricator instance.

[Unittests] Fix plugins test
ClosedPublic

Authored by miyuki on Apr 19 2018, 5:45 AM.

Details

Summary

Currently the PluginsTests.LoadPlugin unit test is failing in
LLVM configurations that have LLVM_EXPORT_SYMBOLS_FOR_PLUGINS enabled
because the EnableABIBreakingChecks symbol is missing.

This patch fixes the issue by linking some additional libraries to the
test plugin if LLVM_EXPORT_SYMBOLS_FOR_PLUGINS is enabled.

Diff Detail

Event Timeline

miyuki created this revision.Apr 19 2018, 5:45 AM
philip.pfaffe accepted this revision.Apr 19 2018, 6:35 AM

LGTM, and solves the issue locally.

Thanks for fixing!

This revision is now accepted and ready to land.Apr 19 2018, 6:35 AM
This revision was automatically updated to reflect the committed changes.