This is an archive of the discontinued LLVM Phabricator instance.

[LibFuzzer] Try to unbreak the `FuzzerMutate.ShuffleBytes1` unit test
ClosedPublic

Authored by delcypher on Apr 18 2018, 5:54 AM.

Details

Summary

[LibFuzzer] Try to unbreak the FuzzerMutate.ShuffleBytes1 unit test.

This test is failing on my Linux box. Just increasing the number of
iterations works around this. The divergence is likely due to
our reliance on std::shuffle() which is not guaranteed to have
the same behaviour across platforms.

This is a strong argument for us to implement our own shuffle
function to avoid divergence in behaviour across platforms.

Diff Detail

Repository
rL LLVM

Event Timeline

delcypher created this revision.Apr 18 2018, 5:54 AM
Herald added a subscriber: Restricted Project. · View Herald TranscriptApr 18 2018, 5:54 AM
kcc accepted this revision.Apr 18 2018, 12:10 PM

LGTM

This revision is now accepted and ready to land.Apr 18 2018, 12:10 PM
This revision was automatically updated to reflect the committed changes.