[libcxx] [test] Remove nonportable that errc::is_a_directory produces "Is a directory" from ios_base::failure tests

[BillyONeal]

Summary

Remove nonportable assumption in io_error tests that std::errc::is_a_directory has message "Is a directory". On MSVC++ it reports "is a directory" (with a lowercase I).

[BillyONeal]

Added missing <system_error> include in one of the tests.

[mclow.lists]

I'm fine with this change, but I'm wondering:

• if there are similar tests in the filesystem test suite, and you haven't tripped over them because you spelled your error message the same as we did.
• Should part of this test be moved into test/libcxx

[BillyONeal]

In D45715#1075665, @mclow.lists wrote:

• if there are similar tests in the filesystem test suite, and you haven't tripped over them because you spelled your error message the same as we did.

Almost certainly. But we aren't running your filesystem tests yet because they are still under experimental. There are probably a lot of POSIX assumptions everywhere in there given the root_name parsing business.

In D45715#1075665, @mclow.lists wrote:

• Should part of this test be moved into test/libcxx

That one's up to you. I don't think the specific message matters to this test; clearly the existing asserts for io_errc::stream don't care about a specific message (which is why they worked on our implementation).

[BillyONeal]

D:\msvc\src\qa\VC\Libs\libcxx\upstream>git svn dcommit
Committing to https://llvm.org/svn/llvm-project/libcxx/trunk ...
Authentication realm: https://llvm.org:443 LLVM Subversion repository
Password for 'bion':

M       test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_char_pointer_error_code.pass.cpp
M       test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_string_error_code.pass.cpp

Committed r330791

M       test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_char_pointer_error_code.pass.cpp
M       test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_string_error_code.pass.cpp

r330791 = efac6e5df9109748822bd3b5b533b35257a110f4 (refs/remotes/llvm/master)
No changes between e69aef2e1f9cb3ad085a9ddcc2f432f8f7c8c182 and refs/remotes/llvm/master
Resetting to the latest refs/remotes/llvm/master

test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_char_pointer_error_code.pass.cpp

 // <ios>
 
 // class ios_base::failure
 
 // explicit failure(const char* msg, const error_code& ec = io_errc::stream);
 
 #include <ios>
 #include <string>
+#include <system_error>
 #include <cassert>
 
 int main()
 {
     {
         std::string what_arg("io test message");
         std::ios_base::failure se(what_arg.c_str(), make_error_code(std::errc::is_a_directory));
         assert(se.code() == std::make_error_code(std::errc::is_a_directory));
         std::string what_message(se.what());
         assert(what_message.find(what_arg) != std::string::npos);
-        assert(what_message.find("Is a directory") != std::string::npos);
+        assert(what_message.find(std::generic_category().message(static_cast<int>
+            (std::errc::is_a_directory))) != std::string::npos);
     }
     {
         std::string what_arg("io test message");
         std::ios_base::failure se(what_arg.c_str());
         assert(se.code() == std::make_error_code(std::io_errc::stream));
         std::string what_message(se.what());
         assert(what_message.find(what_arg) != std::string::npos);
         assert(what_message.find(std::iostream_category().message(static_cast<int>
             (std::io_errc::stream))) != std::string::npos);
     }
 }

test/std/input.output/iostreams.base/ios.base/ios.types/ios_failure/ctor_string_error_code.pass.cpp

int main()
     static_assert((std::is_base_of<std::system_error, std::ios_base::failure>::value), "");
 
     {
         std::string what_arg("io test message");
         std::ios_base::failure se(what_arg, make_error_code(std::errc::is_a_directory));
         assert(se.code() == std::make_error_code(std::errc::is_a_directory));
         std::string what_message(se.what());
         assert(what_message.find(what_arg) != std::string::npos);
-        assert(what_message.find("Is a directory") != std::string::npos);
+        assert(what_message.find(std::generic_category().message(static_cast<int>
+            (std::errc::is_a_directory))) != std::string::npos);
     }
     {
         std::string what_arg("io test message");
         std::ios_base::failure se(what_arg);
         assert(se.code() == std::make_error_code(std::io_errc::stream));
         std::string what_message(se.what());
         assert(what_message.find(what_arg) != std::string::npos);
         assert(what_message.find(std::iostream_category().message(static_cast<int>
             (std::io_errc::stream))) != std::string::npos);
     }
 }