This is an archive of the discontinued LLVM Phabricator instance.

[LLVMTestingSupport] Add explicit linkage to LLVMSupport
ClosedPublic

Authored by mgorny on Apr 7 2018, 1:41 PM.

Download Raw Diff

Details

Reviewers

Commits

rG47671e31cd91: [LLVMTestingSupport] Add explicit linkage to LLVMSupport
rL329522: [LLVMTestingSupport] Add explicit linkage to LLVMSupport

Summary

Explicitly link LLVMTestingSupport library against LLVMSupport. This
is necessary to fix linking errors when LLVMTestingSupport is built
as a shared library (with BUILD_SHARED_LIBS=ON) and -Wl,-z,defs is used.

[This is needed to fix clang+clang-tools-extra build on Gentoo.]

Diff Detail

Repository: rL LLVM

Event Timeline

mgorny created this revision.Apr 7 2018, 1:41 PM

mgorny added a child revision: D45409: [cmake] Include LLVMTestingSupport when doing stand-alone build.Apr 7 2018, 1:46 PM

Lgtm

W dniu nie, 08.04.2018 o godzinie 00∶13 +0000, użytkownik Zachary Turner
napisał:

Lgtm

Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Apr 7 2018, 11:53 PM

Closed by commit rL329522: [LLVMTestingSupport] Add explicit linkage to LLVMSupport (authored by mgorny). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

llvm/

trunk/

lib/

Testing/

Support/

CMakeLists.txt

5 lines

Diff 141528

llvm/trunk/lib/Testing/Support/CMakeLists.txt

	add_definitions(-DGTEST_LANG_CXX11=1)			add_definitions(-DGTEST_LANG_CXX11=1)
	add_definitions(-DGTEST_HAS_TR1_TUPLE=0)			add_definitions(-DGTEST_HAS_TR1_TUPLE=0)

	add_llvm_library(LLVMTestingSupport			add_llvm_library(LLVMTestingSupport
	Error.cpp			Error.cpp

	BUILDTREE_ONLY			BUILDTREE_ONLY

	ADDITIONAL_HEADER_DIRS			ADDITIONAL_HEADER_DIRS
	${LLVM_MAIN_INCLUDE_DIR}/llvm/Testing/Support			${LLVM_MAIN_INCLUDE_DIR}/llvm/Testing/Support

				LINK_COMPONENTS
				Support
	)			)

	include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include)			include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googletest/include)
	include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include)			include_directories(${LLVM_MAIN_SRC_DIR}/utils/unittest/googlemock/include)
	target_link_libraries(LLVMTestingSupport PRIVATE gtest)			target_link_libraries(LLVMTestingSupport PRIVATE gtest)
	No newline at end of file