Page MenuHomePhabricator

[bugpoint] Fix crash when testing for miscompilation
ClosedPublic

Authored by ajanik on Apr 6 2018, 5:18 AM.

Details

Summary

Method BugDriver::performFinalCleanups(...) would delete Module object it worked on, which was also deleted by its caller (e.g. TestCodeGenerator(...)). Changed the code to avoid double delete and make Module ownership slightly clearer.

Diff Detail

Event Timeline

ajanik created this revision.Apr 6 2018, 5:18 AM
espindola edited reviewers, added: espindola; removed: rafael.Apr 6 2018, 9:14 AM
This revision is now accepted and ready to land.Apr 6 2018, 9:19 AM
davide accepted this revision.Apr 12 2018, 8:25 AM

LGTM

@espindola @davide, could you commit this change?