[ARC] Add LImm support for J/JL

[yan_luo]

Summary

Add support for Jumps with LImm

[petecoup]

Hi Yan,

Thanks again for doing this!
Adding Tatyana.

[tatyana-krasnukha]

Hello Yan,

Thank you for this addition!

LGTM. Just a small request - follow common style for comments, please (start with uppercase letter and end with '.').

[yan_luo]

Pete / Tatyana,

Thanks for your review!

[yan_luo]

Pete / Tatyana,

I updated the diff, please review it again, thanks!

[tatyana-krasnukha]

It looks ready to land. I can do it for you, if needed.

[petecoup]

Yes, this looks good to me.

[yan_luo]

Pete / Tatyana,

Thanks for the review! It is landed in r330031.

[yan_luo]

330031

lib/Target/ARC/ARCInstrInfo.td

let isBranch = 1, isTerminator = 1 in {
 
   def BRcc_ru6_p : PseudoInstARC<(outs),
                                  (ins btarget:$T, GPR32:$B, i32imm:$C, ccond:$cc),
                                  "pbr$cc\t$B, $C, $T",
                                  [(ARCbrcc bb:$T, i32:$B, immU6:$C, imm32:$cc)]>
                                  { let Size = 8; }
 } // let isBranch, isTerminator
 
-// Indirect, unconditional Jump.
-let isBranch = 1, isTerminator = 1, isBarrier = 1, isIndirectBranch = 1 in
+// Unconditional Jump.
+let isBranch = 1, isTerminator = 1, isBarrier = 1 in {
+  // Indirect.
+  let isIndirectBranch = 1 in
   def J :  F32_DOP_RR<0b00100, 0b100000, 0,
                       (outs), (ins GPR32:$C),
                       "j\t[$C]", [(brind i32:$C)]>;
 
+  // Direct.
+  def J_LImm : F32_DOP_RLIMM<0b00100, 0b100000, 0,
+                             (outs), (ins i32imm:$LImm),
+                             "j\t$LImm", []>;
+}
+
 // Call instructions.
 let isCall = 1, isBarrier = 1, Defs = [BLINK], Uses = [SP] in {
   // Direct unconditional call.
   def BL : F32_BR1_BL_UCOND_FAR<(outs), (ins calltargetS25:$S25),
                       "bl\t$S25", [(ARCBranchLink tglobaladdr:$S25)]>;
 
   // Indirect unconditional call.
   let isIndirectBranch = 1 in
   def JL : F32_DOP_RR<0b00100, 0b100010, 0, (outs), (ins GPR32:$C),
                      "jl\t[$C]", [(ARCJumpLink i32:$C)]>;
+
+  // Direct unconditional call.
+  def JL_LImm : F32_DOP_RLIMM<0b00100, 0b100010, 0, (outs), (ins i32imm:$LImm),
+                              "jl\t$LImm", []>;
 } // let isCall, isBarrier, Defs, Uses
 
 // Pattern to generate BL instruction.
 def : Pat<(ARCBranchLink texternalsym:$dst), (BL texternalsym:$dst)>;
 
 // Return from call.
 let isReturn = 1, isTerminator = 1, isBarrier = 1  in
 // This is a specialized 2-byte instruction that doesn't generalize

test/MC/Disassembler/ARC/misc.txt

 0x4c 0x26 0x00 0x90
 
 # CHECK: cmp %r23, 1
 0x4c 0x27 0x40 0xa0
 
 # CHECK: jl [%r21]
 0x22 0x20 0x40 0x05
 
+# CHECK: jl 12345
+0x22 0x20 0x80 0x0f 0x00 0x00 0x39 0x30
+
 # CHECK: j [%r3]
 0x20 0x20 0xc0 0x00
 
+# CHECK: j 12345
+0x20 0x20 0x80 0x0f 0x00 0x00 0x39 0x30
+
 # CHECK: seteq %r3, %fp, %r1
 0x38 0x23 0x43 0x30
 
 # CHECK: seteq %r3, %fp, 17
 0x78 0x23 0x43 0x34
 
 # CHECK: seteq %fp, %fp, -1
 0xb8 0x23 0xff 0x3f