Page MenuHomePhabricator

[ThinLTO] Add an option to force summary call edges cold for debugging
ClosedPublic

Authored by tejohnson on Mar 29 2018, 1:49 PM.

Details

Summary

Useful to selectively disable importing into specific modules for
debugging/triaging/workarounds.

Diff Detail

Repository
rL LLVM

Event Timeline

tejohnson created this revision.Mar 29 2018, 1:49 PM
tejohnson updated this revision to Diff 140325.Mar 29 2018, 1:55 PM

Remove change accidentlly included

eraman added inline comments.Mar 29 2018, 5:44 PM
lib/Analysis/ModuleSummaryAnalysis.cpp
331 ↗(On Diff #140325)

Is this the desired behavior or should the flag not affect these edges that are forced to be inlined in AutoFDO? One can argue for preserving critical edges so that the profile gets applied correctly. If you think this behavior is desired, please mention this in the description text of the flag.

tejohnson added inline comments.Mar 30 2018, 10:39 AM
lib/Analysis/ModuleSummaryAnalysis.cpp
331 ↗(On Diff #140325)

I think both options are potentially useful, so I have changed this to an enum so that we can support both.

Address comment

eraman accepted this revision.Mar 30 2018, 1:36 PM
This revision is now accepted and ready to land.Mar 30 2018, 1:36 PM
This revision was automatically updated to reflect the committed changes.