Page MenuHomePhabricator

[X86] Remove SplitBinaryOpsAndApply and use SplitOpsAndApply by adding curly braces around the ops.
ClosedPublic

Authored by craig.topper on Mar 12 2018, 4:32 PM.

Details

Summary

Unless you were intentionally avoiding this syntax? I saw you mentioned makeArrayRef in your commit that added SplitOpsAndApply.

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Mar 12 2018, 4:32 PM

I hit some problems with ArrayRef and initializer lists that I had to fix again with rL327241 - not sure if this will be the same - you don't have the explicit ArrayRef constructor which might fix the problem

RKSimon accepted this revision.Mar 13 2018, 7:23 AM

I hit some problems with ArrayRef and initializer lists that I had to fix again with rL327241 - not sure if this will be the same - you don't have the explicit ArrayRef constructor which might fix the problem

LGTM - assuming this works alright.

This revision is now accepted and ready to land.Mar 13 2018, 7:23 AM
This revision was automatically updated to reflect the committed changes.