This is an archive of the discontinued LLVM Phabricator instance.

CodeGen: simplify and validate exception personalities
ClosedPublic

Authored by compnerd on Mar 8 2018, 3:46 PM.

Details

Reviewers
rnk
smeenai
Summary

Simplify the dispatching for the personality routines. This really had
no test coverage previously, so add test coverage for the various cases.
This turns out to be pretty complicated as the various languages and
models interact to change personalities around.

You really should feel bad for the compiler if you are using exceptions.
There is no reason for this type of cruelty.

Diff Detail

Repository
rC Clang

Event Timeline

compnerd created this revision.Mar 8 2018, 3:46 PM
compnerd updated this revision to Diff 137668.Mar 8 2018, 3:54 PM

add more context

rnk accepted this revision.Mar 8 2018, 5:35 PM

lgtm, thanks! This is nicer.

This revision is now accepted and ready to land.Mar 8 2018, 5:35 PM
compnerd closed this revision.Mar 8 2018, 11:09 PM

SVN r327105