Page MenuHomePhabricator

Avoid definining more GCC specific predefined macros in clang-cl
ClosedPublic

Authored by ehsan on Jul 8 2014, 5:29 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

ehsan updated this revision to Diff 11156.Jul 8 2014, 5:29 AM
ehsan retitled this revision from to Avoid definining more GCC specific predefined macros in clang-cl.
ehsan updated this object.
ehsan edited the test plan for this revision. (Show Details)
ehsan added reviewers: hansw, rnk.
ehsan added a subscriber: Unknown Object (MLST).

I don't think that MSVC compat is the right predicate here, this has more to do with targeting the msvc environment.

So which flag should I use instead? Honestly these different flags confuse me and I'm not sure which one is supposed to be used for which purpose.

triton added a subscriber: triton.Jul 9 2014, 9:02 AM
In D4419#6, @ehsan wrote:

So which flag should I use instead? Honestly these different flags confuse me and I'm not sure which one is supposed to be used for which purpose.

Maybe you can use the "msvc" environment part of the triple for this.

ehsan closed this revision.Jul 10 2014, 11:53 AM
ehsan updated this revision to Diff 11284.

Closed by commit rL212753 (authored by @ehsan).