[LNT] Make new Order template in Compare To in v4_run.html view.

[marxin]

Summary

I would consider it handy to have a template for Compare to. One can add for instance a revision of the Order.

[marxin]

It should be Run template (and not Order template).

[marxin]

Different URLs are needed, thus I've added a new argument to template render_compare_to_run.

[marxin]

May I please remind a patch review.

[MatzeB]

This seems straightforward.

lnt/trunk/lnt/server/ui/templates/local.html

 {# A file for putting site specific customizations. Ex 1234 #}
 
 {# This is what to draw before an order. #}
 {% set prefix = "" %}
 
 {% macro render_order_link(order) -%}
     <a href="{{v4_url_for('.v4_order', id=order.id)}}">{{ prefix }}{{order.llvm_project_revision}}</a>
 {%- endmacro %}
 
+{% macro render_compare_to_run(run, url) -%}
+<a href="{{url}}"><span class="utctime">{{ run.start_time.isoformat() }}</span></a>
+{%- endmacro %}
+
 {# Some example settings from llvm.org. #}
 {#
     <!---On llvm.org we use SVN, so put an r in front. Ex. r1234 -->
 
     {% set prefix = "r" %}
 
 
     <!-- And link the the llvm.org viewvc. -->
 
     {% macro render_order_link(order) -%}
         <a href="{{v4_url_for('.v4_order', id=order.id)}}">{{prefix}}{{order.llvm_project_revision}}</a>
         <a href="http://llvm.org/viewvc/llvm-project?view=revision&revision={{order.llvm_project_revision}}">
             <i class="icon-share-alt"></i></a>
     {%- endmacro %}
 #}

lnt/trunk/lnt/server/ui/templates/v4_run.html

 {% import "utils.html" as utils %}
+{% import "local.html" as local %}
 
 {% set hash_field = ts.Sample.get_hash_of_binary_field() %}
 {% set machine = run.machine %}
 {% set neighboring_runs = request_info.neighboring_runs %}
 {% set comparison_neighboring_runs = request_info.comparison_neighboring_runs %}
 
 {% extends "layout.html" %}
 {% set components = [(ts.name, v4_url_for(".v4_recent_activity")),
$('.profile-prev-only').tooltip();
   </ul>
 
   <h4>Runs:</h4>
   <ul>
   {# Show a small number of neighboring runs. #}
   {% for r in neighboring_runs %}
     <li>
       {{ "<b>"|safe if r.id == run.id else "" }}
-      <a href="{{v4_url_for('.v4_run', id=r.id)}}"><span class="utctime">{{ r.start_time.isoformat() }}</span></a>
+      {{ local.render_compare_to_run(r, v4_url_for('.v4_run', id=r.id)) }}
       {{ "</b>"|safe if r.id == run.id else "" }}
     </li>
   {% endfor %}
   </ul>
   {# Show a small number of runs in the neighborhood of the comparison run. #}
   {% if comparison_neighboring_runs %}
     <h4>Compare To:</h4>
     <ul>
     {% for r in comparison_neighboring_runs %}
       <li>
         {{ "<b>"|safe if compare_to and r.id == compare_to.id else "" }}
-        <a href="{{v4_url_for('.v4_run', id=run.id, compare_to=r.id)}}"><span class="utctime">{{ r.start_time.isoformat() }}</span></a>
+        {{ local.render_compare_to_run(r, v4_url_for('.v4_run', id=run.id, compare_to=r.id)) }}
         {{ "</b>"|safe if compare_to and r.id == compare_to.id else "" }}
       </li>
     {% endfor %}
     </ul>
   {% endif %}
 {% endblock %}
 
 {% block body %}