This is an archive of the discontinued LLVM Phabricator instance.

Differential D43953

clangformat-vs: Fix plugin not correctly loading in some cases
AcceptedPublic

Authored by fxroure-ubisoft on Mar 1 2018, 9:42 AM.

Details

Reviewers
kristina
Group Reviewers
Restricted Project
Summary

When installing the clang-format visual studio plugin sometimes it won't be loaded correctly (some users seem to have the same issue) and we must do

devenv.exe /updateconfiguration

in order to fix the installation (normally visual studio should automatically execute this command whenever you install a plugin).
This issue seems to come from the fact that the plugin manifest does not list a VsPackage as an asset.
After adding it to assets list (code change in this review) installation of the plugin was working and when uninstalling the plugin visual correctly ask to restart it (that was not the case before).

Diff Detail

Event Timeline

fxroure-ubisoft created this revision.Mar 1 2018, 9:42 AM
fxroure-ubisoft created this object with edit policy "fxroure-ubisoft (François-Xavier Roure)".
Herald added a subscriber: cfe-commits. · View Herald TranscriptMar 1 2018, 9:42 AM
kristina accepted this revision as: kristina.EditedAug 3 2018, 10:05 AM
kristina added a subscriber: kristina.

Seems something that's not easy to test or reproduce even with VS (the VS tool itself is 3rd party if I understand right) but it looks sane. Didn't seem to cause any problems when trying with VS.

This revision is now accepted and ready to land.Aug 3 2018, 10:05 AM

Revision Contents

PathSize
tools/
clang-format-vs/
3 lines

Diff 136545

tools/clang-format-vs/source.extension.vsixmanifest.in

Show All 10 Lines <Installation InstalledByMsi="false">
<InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[11.0, 15.0]" /> <InstallationTarget Id="Microsoft.VisualStudio.Pro" Version="[11.0, 15.0]" />
</Installation> </Installation>
<Dependencies> <Dependencies>
<Dependency Id="Microsoft.VisualStudio.MPF" MinVersion="11.0" DisplayName="Visual Studio MPF" /> <Dependency Id="Microsoft.VisualStudio.MPF" MinVersion="11.0" DisplayName="Visual Studio MPF" />
</Dependencies> </Dependencies>
<Prerequisites> <Prerequisites>
<Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[11.0,)" DisplayName="Visual Studio core editor" /> <Prerequisite Id="Microsoft.VisualStudio.Component.CoreEditor" Version="[11.0,)" DisplayName="Visual Studio core editor" />
</Prerequisites> </Prerequisites>
<Assets>
<Asset Type="Microsoft.VisualStudio.VsPackage" d:Source="Project" d:ProjectName="%CurrentProject%" Path="|%CurrentProject%;PkgdefProjectOutputGroup|" />
</Assets>
</PackageManifest> </PackageManifest>