This is an archive of the discontinued LLVM Phabricator instance.

[MinGW] Fix --{start,end}-group.
ClosedPublic

Authored by ruiu on Feb 27 2018, 3:43 PM.

Download Raw Diff

Details

Reviewers

Commits

rGb34bd34fd27e: [MinGW] Fix --{start,end}-group.
rLLD326478: [MinGW] Fix --{start,end}-group.
rL326478: [MinGW] Fix --{start,end}-group.

Summary

Currently --start-group=foo is accidentally accepted by the MinGW driver.

Diff Detail

Repository: rL LLVM

Event Timeline

ruiu created this revision.Feb 27 2018, 3:43 PM

Harbormaster completed remote builds in B15489: Diff 136167.Feb 27 2018, 3:43 PM

LGTM

This revision is now accepted and ready to land.Feb 27 2018, 8:44 PM

Anything blocking committing this one?

No, I just forgot to commit this.

Closed by commit rL326478: [MinGW] Fix --{start,end}-group. (authored by ruiu). · Explain WhyMar 1 2018, 12:41 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents

Path

Size

lld/

trunk/

MinGW/

Options.td

4 lines

test/

MinGW/

driver.test

2 lines

Diff 136586

lld/trunk/MinGW/Options.td

	Show First 20 Lines • Show All 45 Lines • ▼ Show 20 Lines
	// Currently stubs to avoid errors			// Currently stubs to avoid errors
	def Bdynamic: F<"Bdynamic">, HelpText<"Link against shared libraries">;			def Bdynamic: F<"Bdynamic">, HelpText<"Link against shared libraries">;
	def Bstatic: F<"Bstatic">, HelpText<"Do not link against shared libraries">;			def Bstatic: F<"Bstatic">, HelpText<"Do not link against shared libraries">;
	def O: Joined<["-"], "O">, HelpText<"Optimize output file size">;			def O: Joined<["-"], "O">, HelpText<"Optimize output file size">;
	def build_id: F<"build-id">;			def build_id: F<"build-id">;
	def disable_auto_image_base: F<"disable-auto-image-base">;			def disable_auto_image_base: F<"disable-auto-image-base">;
	def enable_auto_image_base: F<"enable-auto-image-base">;			def enable_auto_image_base: F<"enable-auto-image-base">;
	def enable_auto_import: F<"enable-auto-import">;			def enable_auto_import: F<"enable-auto-import">;
	def end_group: J<"end-group">;			def end_group: F<"end-group">;
	def full_shutdown: Flag<["--"], "full-shutdown">;			def full_shutdown: Flag<["--"], "full-shutdown">;
	def high_entropy_va: F<"high-entropy-va">, HelpText<"Enable 64-bit ASLR">;			def high_entropy_va: F<"high-entropy-va">, HelpText<"Enable 64-bit ASLR">;
	def major_image_version: S<"major-image-version">;			def major_image_version: S<"major-image-version">;
	def minor_image_version: S<"minor-image-version">;			def minor_image_version: S<"minor-image-version">;
	def no_seh: F<"no-seh">;			def no_seh: F<"no-seh">;
	def nxcompat: F<"nxcompat">, HelpText<"Enable data execution prevention">;			def nxcompat: F<"nxcompat">, HelpText<"Enable data execution prevention">;
	def pic_executable: F<"pic-executable">;			def pic_executable: F<"pic-executable">;
	def sysroot: J<"sysroot">, HelpText<"Sysroot">;			def sysroot: J<"sysroot">, HelpText<"Sysroot">;
	def start_group: J<"start-group">;			def start_group: F<"start-group">;
	def tsaware: F<"tsaware">, HelpText<"Create Terminal Server aware executable">;			def tsaware: F<"tsaware">, HelpText<"Create Terminal Server aware executable">;
	def v: Flag<["-"], "v">, HelpText<"Display the version number">;			def v: Flag<["-"], "v">, HelpText<"Display the version number">;
	def version: F<"version">, HelpText<"Display the version number and exit">;			def version: F<"version">, HelpText<"Display the version number and exit">;

	// Alias			// Alias
	def alias_entry_e: JoinedOrSeparate<["-"], "e">, Alias<entry>;			def alias_entry_e: JoinedOrSeparate<["-"], "e">, Alias<entry>;
	def alias_strip_s: Flag<["-"], "s">, Alias<strip_all>;			def alias_strip_s: Flag<["-"], "s">, Alias<strip_all>;

lld/trunk/test/MinGW/driver.test

	Show First 20 Lines • Show All 118 Lines • ▼ Show 20 Lines
	RUN: ld.lld -### -m i386pep foo.o -icf=none \| FileCheck -check-prefix ICF-NONE %s			RUN: ld.lld -### -m i386pep foo.o -icf=none \| FileCheck -check-prefix ICF-NONE %s
	RUN: ld.lld -### -m i386pep foo.o --icf=safe \| FileCheck -check-prefix ICF-NONE %s			RUN: ld.lld -### -m i386pep foo.o --icf=safe \| FileCheck -check-prefix ICF-NONE %s
	RUN: ld.lld -### -m i386pep foo.o -icf=safe \| FileCheck -check-prefix ICF-NONE %s			RUN: ld.lld -### -m i386pep foo.o -icf=safe \| FileCheck -check-prefix ICF-NONE %s
	ICF-NONE: -opt:noicf			ICF-NONE: -opt:noicf

	RUN: ld.lld -### -m i386pep foo.o --icf=all \| FileCheck -check-prefix ICF %s			RUN: ld.lld -### -m i386pep foo.o --icf=all \| FileCheck -check-prefix ICF %s
	RUN: ld.lld -### -m i386pep foo.o -icf=all \| FileCheck -check-prefix ICF %s			RUN: ld.lld -### -m i386pep foo.o -icf=all \| FileCheck -check-prefix ICF %s
	ICF: -opt:icf			ICF: -opt:icf

				RUN: ld.lld -### -m i386pep --start-group foo.o --end-group