[InstCombine] Split the FP constant code out of lookThroughFPExtensions and use nullptr as a sentinel.

[craig.topper]

Summary

[InstCombine] Split the FP constant shrinking code out of lookThroughFPExtensions and turn it into a helper function that returns nullptr on failure.

Currently this code's control flow very much assumes that there are no meaningful checks after determining that it's a ConstantFP. So whenever it wants to stop it just does "return V".

This patch just moves all the code into a helper function and returns nullptr when it wants to stop.

I've split this from D43774 while I try to figure out how to best handle the vector case there. But this change by itself at least seemed like a readability improvement.

[spatel]

LGTM.

lib/Transforms/InstCombine/InstCombineCasts.cpp

1442–1443 ↗

(On Diff #136158)

Since we're going to fix this: a loop is unnecessary here AFAIK. isEliminableCastPair() would always squash those?

llvm/trunk/lib/Transforms/InstCombine/InstCombineCasts.cpp

static Constant *fitsInFPType(ConstantFP *CFP, const fltSemantics &Sem) {
   bool losesInfo;
   APFloat F = CFP->getValueAPF();
   (void)F.convert(Sem, APFloat::rmNearestTiesToEven, &losesInfo);
   if (!losesInfo)
     return ConstantFP::get(CFP->getContext(), F);
   return nullptr;
 }
 
+static Constant *shrinkFPConstant(ConstantFP *CFP) {
+  if (CFP->getType() == Type::getPPC_FP128Ty(CFP->getContext()))
+    return nullptr;  // No constant folding of this.
+  // See if the value can be truncated to half and then reextended.
+  if (Constant *NewCFP = fitsInFPType(CFP, APFloat::IEEEhalf()))
+    return NewCFP;
+  // See if the value can be truncated to float and then reextended.
+  if (Constant *NewCFP = fitsInFPType(CFP, APFloat::IEEEsingle()))
+    return NewCFP;
+  if (CFP->getType()->isDoubleTy())
+    return nullptr;  // Won't shrink.
+  if (Constant *NewCFP = fitsInFPType(CFP, APFloat::IEEEdouble()))
+    return NewCFP;
+  // Don't try to shrink to various long double types.
+  return nullptr;
+}
+
 /// Look through floating-point extensions until we get the source value.
 static Value *lookThroughFPExtensions(Value *V) {
   while (auto *FPExt = dyn_cast<FPExtInst>(V))
     V = FPExt->getOperand(0);
 
   // If this value is a constant, return the constant in the smallest FP type
   // that can accurately represent it.  This allows us to turn
   // (float)((double)X+2.0) into x+2.0f.
-  if (auto *CFP = dyn_cast<ConstantFP>(V)) {
-    if (CFP->getType() == Type::getPPC_FP128Ty(V->getContext()))
-      return V;  // No constant folding of this.
-    // See if the value can be truncated to half and then reextended.
-    if (Value *V = fitsInFPType(CFP, APFloat::IEEEhalf()))
-      return V;
-    // See if the value can be truncated to float and then reextended.
-    if (Value *V = fitsInFPType(CFP, APFloat::IEEEsingle()))
-      return V;
-    if (CFP->getType()->isDoubleTy())
-      return V;  // Won't shrink.
-    if (Value *V = fitsInFPType(CFP, APFloat::IEEEdouble()))
-      return V;
-    // Don't try to shrink to various long double types.
-  }
+  if (auto *CFP = dyn_cast<ConstantFP>(V))
+    if (Constant *NewCFP = shrinkFPConstant(CFP))
+      return NewCFP;
 
   return V;
 }
 
 Instruction *InstCombiner::visitFPTrunc(FPTruncInst &CI) {
   if (Instruction *I = commonCastTransforms(CI))
     return I;
   // If we have fptrunc(OpI (fpextend x), (fpextend y)), we would like to