This is an archive of the discontinued LLVM Phabricator instance.

Differential D43784

Un-XFAIL TestCallStdStringFunction.test for Windows
AbandonedPublic

Authored by amccarth on Feb 26 2018, 1:49 PM.

Download Raw Diff

Details

Reviewers

zturner

Summary

This test was passing unexpectedly, which causes ninja to short-circuit out of running the dotest.py tests.

The bug report (https://bugs.llvm.org/show_bug.cgi?id=21765) appears to be obsolete (since it "blocks" another bug that's been fixed).

Diff Detail

Event Timeline

amccarth created this revision.Feb 26 2018, 1:49 PM

Herald added a subscriber: sanjoy. · View Herald TranscriptFeb 26 2018, 1:49 PM

Btw, today I found out that this test is passing just accidentally because the CHECK lines are matching the output printed by the inferior and not the results of the evaluated expressions (the situation may be different on windows, if you don't do stdin/out redirection there).

Nice catch. I'll take a closer look to see what exactly is happening on Windows.

Abandoning. This isn't really working on Windows. The breakpoint fails to set for reasons I don't understand yet.

Revision Contents

Path

Size

lldb/

lit/

Expr/

TestCallStdStringFunction.test

3 lines

Diff 135966

lldb/lit/Expr/TestCallStdStringFunction.test

	# XFAIL: windows
	# -> llvm.org/pr21765

	# RUN: %cxx %p/Inputs/call-function.cpp -g -o %t && %lldb -b -s %s -- %t \| FileCheck %s			# RUN: %cxx %p/Inputs/call-function.cpp -g -o %t && %lldb -b -s %s -- %t \| FileCheck %s

	breakpoint set --file call-function.cpp --line 52			breakpoint set --file call-function.cpp --line 52
	run			run
	print str			print str
	# CHECK: Hello world			# CHECK: Hello world
	print str.c_str()			print str.c_str()
	# CHECK: Hello world			# CHECK: Hello world