This is an archive of the discontinued LLVM Phabricator instance.

[llvm-objcopy] Fix typo in setSymTab and make setters private.
ClosedPublic

Authored by alexander-shaposhnikov on Feb 22 2018, 5:11 PM.

Details

Summary

[NFC] This diff fixes the name of the argument of setSymTab and makes setSymTab/setStrTab private
(to make the public interface a bit cleaner).
(to be honest, I'm not sure if these methods provide any value at all, I would probably remove them, but it's not particularly important)
P.S. I've been working on some other fixes to llvm-objcopy (will create a code review soon), but this tiny change is unrelated that's why I decided to send a separate diff.

Diff Detail

Repository
rC Clang

Event Timeline

jakehehrlich accepted this revision.Feb 22 2018, 6:36 PM

LGTM

Keep the changes coming! I'll be here to review them.

This revision is now accepted and ready to land.Feb 22 2018, 6:36 PM
This revision was automatically updated to reflect the committed changes.