This is an archive of the discontinued LLVM Phabricator instance.

Do not define __STRICT_ANSI__ in clang-cl
ClosedPublic

Authored by • ehsan on Jun 30 2014, 12:32 PM.

Reviewers

hans
• ehsan

Summary

This breaks building the cairo library with MSVC on Windows, because it uses STRICT_ANSI to detect whether the inline keyword is available.

• ehsan retitled this revision from to Do not define __STRICT_ANSI__ in clang-cl.

• ehsan updated this object.

• ehsan edited the test plan for this revision. (Show Details)

• ehsan added a reviewer: hans.

• ehsan added a subscriber: Unknown Object (MLST).

Moved the test.

Landed in r212066.

This revision is now accepted and ready to land.Jun 30 2014, 1:45 PM

Path

Size

lib/

Frontend/

2 lines

test/

Frontend/

6 lines

Show First 20 Lines • Show All 427 Lines • ▼ Show 20 Lines	#undef TOSTR2
// checks that it is necessary to report 4.2.1 (the base GCC version we claim		// checks that it is necessary to report 4.2.1 (the base GCC version we claim
// compatibility with) first.		// compatibility with) first.
Builder.defineMacro("__VERSION__", "\"4.2.1 Compatible " +		Builder.defineMacro("__VERSION__", "\"4.2.1 Compatible " +
Twine(getClangFullCPPVersion()) + "\"");		Twine(getClangFullCPPVersion()) + "\"");

// Initialize language-specific preprocessor defines.		// Initialize language-specific preprocessor defines.

// Standard conforming mode?		// Standard conforming mode?
if (!LangOpts.GNUMode)		if (!LangOpts.GNUMode && !LangOpts.MSVCCompat)
Builder.defineMacro("__STRICT_ANSI__");		Builder.defineMacro("__STRICT_ANSI__");

if (LangOpts.CPlusPlus11)		if (LangOpts.CPlusPlus11)
Builder.defineMacro("__GXX_EXPERIMENTAL_CXX0X__");		Builder.defineMacro("__GXX_EXPERIMENTAL_CXX0X__");

if (LangOpts.ObjC1) {		if (LangOpts.ObjC1) {
if (LangOpts.ObjCRuntime.isNonFragile()) {		if (LangOpts.ObjCRuntime.isNonFragile()) {
Builder.defineMacro("__OBJC2__");		Builder.defineMacro("__OBJC2__");
▲ Show 20 Lines • Show All 444 Lines • Show Last 20 Lines

				// RUN: %clang_cc1 -fms-compatibility -verify %s
				// expected-no-diagnostics

				#if defined(__STRICT_ANSI__)
				#error __STRICT_ANSI__ should not be defined.
				#endif