This is an archive of the discontinued LLVM Phabricator instance.

Differential D43004

[LNT] Set the baseline run id in flask session and not baseline id
AbandonedPublic

Authored by siddhesh on Feb 6 2018, 11:39 PM.

Details

Reviewers
cmatthews
Summary

During set_baseline the function incorrectly sets the baseline id as the baseline key in the flask session instead of the order id. Fix that.

Diff Detail

Repository
rL LLVM

Event Timeline

siddhesh created this revision.Feb 6 2018, 11:39 PM
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 6 2018, 11:39 PM
siddhesh updated this revision to Diff 133158.Feb 6 2018, 11:56 PM
siddhesh retitled this revision from [LNT] Use order_id for the Baselines menu and not id to [LNT] Set the baseline run id in flask session and not baseline id.
siddhesh edited the summary of this revision. (Show Details)

Sorry, the fix should have been in setting of baseline, not in the baseline menu itself. Fixed and tested.

siddhesh abandoned this revision.Dec 9 2020, 2:08 AM

I don't remember anymore why I needed this, so abandoning it.

Revision Contents

PathSize
lnt/
server/
ui/
2 lines

Diff 133158

lnt/server/ui/views.py

Context not available.
if not base: if not base:
return abort(404) return abort(404)
flash("Baseline set to " + base.name, FLASH_SUCCESS) flash("Baseline set to " + base.name, FLASH_SUCCESS)
flask.session[baseline_key()] = id flask.session[baseline_key()] = base.order_id
return redirect(get_redirect_target()) return redirect(get_redirect_target())
Context not available.