This is an archive of the discontinued LLVM Phabricator instance.

Simplify libtool compatibility hack
ClosedPublic

Authored by espindola on Feb 6 2018, 4:00 PM.

Details

Reviewers
ruiu
grimar
Summary

I tested that if I remove "elf" from the message, building a program that uses libtool prints

checking whether to build shared libraries... no

but with this patch it still prints

checking whether to build shared libraries... yes

Diff Detail

Event Timeline

espindola created this revision.Feb 6 2018, 4:00 PM
ruiu accepted this revision.Feb 6 2018, 4:02 PM

LGTM

ELF/DriverUtils.cpp
127

Remove this line from the comment.

This revision is now accepted and ready to land.Feb 6 2018, 4:02 PM

Nice, thanks !