This is an archive of the discontinued LLVM Phabricator instance.

Differential D42894

[LNT] Use session saved baseline in run comparison report
AcceptedPublic

Authored by siddhesh on Feb 4 2018, 11:41 AM.

Details

Reviewers
cmatthews
Summary

The run comparison report only uses the GET key 'baseline' as a parameter to set the baseline for runs and does not use the baseline set in the session by selecting one of the "Baselines" menu options. Recognize the session saved baseline and use it if there is no 'baseline' GET variable.

Diff Detail

Repository
rL LLVM

Event Timeline

siddhesh created this revision.Feb 4 2018, 11:41 AM
Herald added a subscriber: llvm-commits. · View Herald TranscriptFeb 4 2018, 11:41 AM
siddhesh retitled this revision from Use session saved baseline in run comparison report to [LNT] Use session saved baseline in run comparison report.Feb 5 2018, 11:50 PM
siddhesh added a reviewer: cmatthews.
Andi added a subscriber: Andi.Feb 2 2020, 10:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 2 2020, 10:08 AM
cmatthews accepted this revision.Feb 3 2020, 11:38 AM

LGTM

This revision is now accepted and ready to land.Feb 3 2020, 11:38 AM

Revision Contents

PathSize
lnt/
server/
ui/
9 lines

Diff 132776

lnt/server/ui/views.py

Context not available.
baseline_str = request.args.get('baseline') baseline_str = request.args.get('baseline')
if baseline_str: if baseline_str:
baseline_id = int(baseline_str) baseline_id = int(baseline_str)
baseline = session.query(ts.Run).filter_by(id=baseline_id).first()
if baseline is None:
flash("Could not find baseline " + baseline_str, FLASH_DANGER)
else: else:
baseline = None baseline_id = flask.session.get(baseline_key())
baseline = session.query(ts.Run).filter_by(id=baseline_id).first()
if baseline is None and baseline_str:
flash("Could not find baseline " + baseline_str, FLASH_DANGER)
# Gather the runs to use for statistical data. # Gather the runs to use for statistical data.
comparison_start_run = compare_to or self.run comparison_start_run = compare_to or self.run
Context not available.