This is an archive of the discontinued LLVM Phabricator instance.

Differential D42827

Don't accept unsuitable ELF files such as executables or core files.
ClosedPublic

Authored by ruiu on Feb 1 2018, 4:04 PM.

Details

Reviewers
• rafael
Commits
rGd0de239f7025: Don't accept unsuitable ELF files such as executables or core files.
rL324041: Don't accept unsuitable ELF files such as executables or core files.
rLLD324041: Don't accept unsuitable ELF files such as executables or core files.
Summary

Don't accept unsuitable ELF files such as executables or core files.

Diff Detail

Repository
rLLD LLVM Linker

Event Timeline

ruiu created this revision.Feb 1 2018, 4:04 PM
Herald added a subscriber: emaste. · View Herald TranscriptFeb 1 2018, 4:04 PM
Harbormaster completed remote builds in B14533: Diff 132499.Feb 1 2018, 4:04 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 1 2018, 4:32 PM
Closed by commit rLLD324041: Don't accept unsuitable ELF files such as executables or core files. (authored by ruiu). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
ELF/
6 lines
test/
ELF/
invalid/
Inputs/
9 lines
5 lines

Diff 132506

ELF/Driver.cpp

Show First 20 Lines • Show All 222 Lines • ▼ Show 20 Lines case file_magic::elf_shared_object:
// need it later. // need it later.
// //
// If a file was specified by -lfoo, the directory part is not // If a file was specified by -lfoo, the directory part is not
// significant, as a user did not specify it. This behavior is // significant, as a user did not specify it. This behavior is
// compatible with GNU. // compatible with GNU.
Files.push_back( Files.push_back(
createSharedFile(MBRef, WithLOption ? path::filename(Path) : Path)); createSharedFile(MBRef, WithLOption ? path::filename(Path) : Path));
return; return;
default: case file_magic::bitcode:
case file_magic::elf_relocatable:
if (InLib) if (InLib)
Files.push_back(make<LazyObjFile>(MBRef, "", 0)); Files.push_back(make<LazyObjFile>(MBRef, "", 0));
else else
Files.push_back(createObjectFile(MBRef)); Files.push_back(createObjectFile(MBRef));
break;
default:
error(Path + ": unknown file type");
} }
} }
// Add a given library by searching it from input search paths. // Add a given library by searching it from input search paths.
void LinkerDriver::addLibrary(StringRef Name) { void LinkerDriver::addLibrary(StringRef Name) {
if (Optional<std::string> Path = searchLibrary(Name)) if (Optional<std::string> Path = searchLibrary(Name))
addFile(*Path, /*WithLOption=*/true); addFile(*Path, /*WithLOption=*/true);
else else
▲ Show 20 Lines • Show All 895 Lines • Show Last 20 Lines

test/ELF/invalid/Inputs/too-short.elf

  • This is a binary file.

test/ELF/invalid/executable.s

# REQUIRES: x86
# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t.o
# RUN: ld.lld -o %t1.exe %t.o
# RUN: not ld.lld -o %t2.exe %t1.exe 2>&1 | FileCheck %s
# CHECK: unknown file type
.global _start
_start:
ret

test/ELF/invalid/too-short.s

# REQUIRES: x86
## too-short.elf file is a truncated ELF.
# RUN: not ld.lld %S/Inputs/too-short.elf -o %t 2>&1 | FileCheck %s
# CHECK: file is too short
ELF/Driver.cpp