[Sema] Add implicit members even for invalid CXXRecordDecls

[ilya-biryukov]

Summary

It should be safe, since other code paths are already generating
implicit members even in invalid CXXRecordDecls (e.g. lookup).

If we don't generate implicit members on CXXRecordDecl's completion,
they will be generated by next lookup of constructors. This causes a
crash when the following conditions are met:

• a CXXRecordDecl is invalid,
• it is provided via ExternalASTSource (e.g. from PCH),
• it has inherited constructors (they create ShadowDecls),
• lookup of its constructors was not run before ASTWriter serialized it.

This may require the ShadowDecls created for inherited constructors to
be removed from the class, but that's no longer possible since class is
provided by ExternalASTSource.

See provided lit test for an example.

[ilya-biryukov]

The following assertion from DeclContext::removeDecl was failing before:

assert((D->NextInContextAndBits.getPointer() || D == LastDecl) &&
       "decl is not in decls list");

[bkramer]

lg

lib/Sema/SemaDecl.cpp

if (CXXRecordDecl *CXXRecord = dyn_cast<CXXRecordDecl>(Record)) {
       if (!CXXRecord->isDependentType()) {
         if (CXXRecord->hasUserDeclaredDestructor()) {
           // Adjust user-defined destructor exception spec.
           if (getLangOpts().CPlusPlus11)
             AdjustDestructorExceptionSpec(CXXRecord,
                                           CXXRecord->getDestructor());
         }
 
-        if (!CXXRecord->isInvalidDecl()) {
-          // Add any implicitly-declared members to this class.
-          AddImplicitlyDeclaredMembersToClass(CXXRecord);
 
+        if (!CXXRecord->isInvalidDecl()) {
           // If we have virtual base classes, we may end up finding multiple
           // final overriders for a given virtual function. Check for this
           // problem now.
           if (CXXRecord->getNumVBases()) {
             CXXFinalOverriderMap FinalOverriders;
             CXXRecord->getFinalOverriders(FinalOverriders);
 
             for (CXXFinalOverriderMap::iterator M = FinalOverriders.begin(),

test/Index/Inputs/crash-preamble-classes.h

+struct Incomplete;
+
+struct X : Incomplete {
+  X();
+};
+
+struct Y : X {
+  using X::X;
+};

test/Index/crash-preamble-classes.cpp

+#include "crash-preamble-classes.h"
+
+struct Z : Y {
+  Z() {}
+};
+
+// RUN: env CINDEXTEST_EDITING=1 \
+// RUN: c-index-test -test-load-source-reparse 5 local -I %S/Inputs %s