This is an archive of the discontinued LLVM Phabricator instance.

[llvm-cov] Fix incorrect usage of .precision specifier in format() call.
ClosedPublic

Authored by Dor1s on Jan 31 2018, 2:09 PM.

Reviewers

Commits

Summary

Existing version doesn't work on Windows as it always prints 0.00.

Repository

rL LLVM

Build Status

Buildable 14488
Build 14488: arc lint + arc unit

Self-approval for a single character change.

This revision is now accepted and ready to land.Jan 31 2018, 2:13 PM

This revision was automatically updated to reflect the committed changes.

Path

Size

tools/

llvm-cov/

2 lines

Show First 20 Lines • Show All 337 Lines • ▼ Show 20 Lines	void CoveragePrinterHTML::emitFileSummary(raw_ostream &OS, StringRef SF,

// Format a coverage triple and add the result to the list of columns.		// Format a coverage triple and add the result to the list of columns.
auto AddCoverageTripleToColumn = [&Columns](unsigned Hit, unsigned Total,		auto AddCoverageTripleToColumn = [&Columns](unsigned Hit, unsigned Total,
float Pctg) {		float Pctg) {
std::string S;		std::string S;
{		{
raw_string_ostream RSO{S};		raw_string_ostream RSO{S};
if (Total)		if (Total)
RSO << format("%6.2f", 7, Pctg) << "% ";		RSO << format("%*.2f", 7, Pctg) << "% ";
else		else
RSO << "- ";		RSO << "- ";
RSO << '(' << Hit << '/' << Total << ')';		RSO << '(' << Hit << '/' << Total << ')';
}		}
const char *CellClass = "column-entry-yellow";		const char *CellClass = "column-entry-yellow";
if (Hit == Total)		if (Hit == Total)
CellClass = "column-entry-green";		CellClass = "column-entry-green";
else if (Pctg < 80.0)		else if (Pctg < 80.0)
▲ Show 20 Lines • Show All 343 Lines • Show Last 20 Lines