This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Silence signed <-> unsigned integer comparison warning
ClosedPublic

Authored by omtcyfz on Jan 28 2018, 3:54 AM.

Details

Summary

num_args is unsigned integer, declared as below:

uint32_t num_args = arg_enum->getChildCount();

Comparison with the signed arg_idx produces a warning when compiled with -Wsign-compare flag, this patch addresses this simple issue without affecting any functionality.

Diff Detail

Repository
rL LLVM

Event Timeline

omtcyfz created this revision.Jan 28 2018, 3:54 AM
asmith accepted this revision.Jan 28 2018, 10:40 AM

Thanks for fixing that!

This revision is now accepted and ready to land.Jan 28 2018, 10:40 AM
davide accepted this revision.Jan 28 2018, 9:56 PM

LGTM. unsigned is probably fine as well. Do you need somebody to commit this on your behalf?

@asmith Thanks!

@davide Thanks for the input!
I'll be able to do land it since I have commit access, thanks!

This revision was automatically updated to reflect the committed changes.