This is an archive of the discontinued LLVM Phabricator instance.

[OMPT] Limit omp_control_tool testcase to 5.0
AbandonedPublic

Authored by protze.joachim on Jan 23 2018, 9:52 AM.

Details

Reviewers
Hahnfeld
jlpeyton
Summary

Starting with OpenMP 5.0 the runtime should provide this function regardless of OMPT support. Therefore, we have one OMPT test, that does not "REQUIRES: ompt". But the function is only available if built with LIBOMP_OMP_VERSION=50. This test fails if the runtime is built with a lower version number.

This patch introduces the OpenMP version as a test feature and adds the REQUIRES line to the test.

Diff Detail

Event Timeline

protze.joachim created this revision.Jan 23 2018, 9:52 AM
protze.joachim added reviewers: Hahnfeld, jlpeyton.
protze.joachim added a subscriber: openmp-commits.
protze.joachim edited the summary of this revision. (Show Details)

NEEDS must be REQUIRES

That's uncommon: For example the tests have always tested __kmpc_taskloop which is only defined for OpenMP 4.5 and later. I think it would be better to disable all tests when not building for the latest OpenMP version - that eliminates one testing dimension that we don't need to worry about.