[cmake] Remove LLVM_HAVE_OPT_VIEWER_MODULES from LLVMConfig

[mgorny]

Summary

Remove the LLVM_HAVE_OPT_VIEWER_MODULES definition from LLVMConfig.
It is not used by any LLVM packages, and it really does not provide
a stable information that other packages could rely on.

Given that opt-viewer is written in Python and installed
unconditionally, there is no strict necessity for the relevant Python
modules to be installed before building LLVM. In particular,
if the missing Python modules are installed after installing LLVM
with opt-viewer, the LLVMConfig module would wrongly suggest that
opt-viewer does not work.

If any package does need to check if opt-viewer has the necessary
dependencies installed, it should manually recheck them at the moment
of execution. If at all, LLVM CMake files may provide macros to help
with that but not a static value.

[anemet]

This is used by Swift. Providing a macro instead of a static value may be a better solution. If you are willing to do that I am OK with that but I have a strong objection against simply removing this.

cmake/modules/LLVMConfig.cmake.in

 set(LLVM_INCLUDE_DIR "@LLVM_CONFIG_INCLUDE_DIRS@")
 set(LLVM_LIBRARY_DIR "@LLVM_CONFIG_LIBRARY_DIRS@")
 
 set(LLVM_DEFINITIONS "@LLVM_DEFINITIONS@")
 set(LLVM_CMAKE_DIR "@LLVM_CONFIG_CMAKE_DIR@")
 set(LLVM_BINARY_DIR "@LLVM_CONFIG_BINARY_DIR@")
 set(LLVM_TOOLS_BINARY_DIR "@LLVM_CONFIG_TOOLS_BINARY_DIR@")
 set(LLVM_TOOLS_INSTALL_DIR "@LLVM_TOOLS_INSTALL_DIR@")
-set(LLVM_HAVE_OPT_VIEWER_MODULES @LLVM_HAVE_OPT_VIEWER_MODULES@)
 
 if(NOT TARGET LLVMSupport)
   set(LLVM_EXPORTED_TARGETS "@LLVM_CONFIG_EXPORTS@")
   include("@LLVM_CONFIG_EXPORTS_FILE@")
   @llvm_config_include_buildtree_only_exports@
 endif()
 
 # By creating intrinsics_gen here, subprojects that depend on LLVM's
 # tablegen-generated headers can always depend on this target whether building
 # in-tree with LLVM or not.
 if(NOT TARGET intrinsics_gen)
   add_custom_target(intrinsics_gen)
 endif()
 
 set_property(GLOBAL PROPERTY LLVM_TARGETS_CONFIGURED On)
 include(${LLVM_CMAKE_DIR}/LLVM-Config.cmake)