Details
Diff Detail
Event Timeline
I haven't checked what other strange things GCC does with -m[no-]abicalls so I'm calling this an initial implementation. The Linux Kernel is one example of a piece of software built with -mno-abicalls.
LGTM with a nit.
We are still a long way from having proper -mno-abicalls support at this point but it's definitely a start.
lib/Target/Mips/MipsSubtarget.h | ||
---|---|---|
60 | Is the 'bit' part of the name intentional? It doesn't look like it refers to any bit/bits. |
lib/Target/Mips/MipsSubtarget.h | ||
---|---|---|
60 | I'm not sure. That's how Matheus named it, so I left it like that. |
lib/Target/Mips/MipsSubtarget.h | ||
---|---|---|
60 | In that case I'm going to drop the 'bit' suffix before I commit. Thanks. |
Committed in r215194.
So far you've mostly been finishing of Matheus's patches but I think you've pretty much got the hang of necessary submission quality, etc so I think you should ask Chris Lattner for commit access. You'll still be subject to pre-commit reviews but you'll be able to commit your own work once you've got a 'LGTM'.
Is the 'bit' part of the name intentional? It doesn't look like it refers to any bit/bits.