This is an archive of the discontinued LLVM Phabricator instance.

[mips] Initial implementation of abicalls.
ClosedPublic

Authored by tomatabacu on Jun 20 2014, 8:53 AM.

Diff Detail

Event Timeline

matheusalmeida retitled this revision from to [mips] Initial implementation of abicalls..
matheusalmeida updated this object.
matheusalmeida edited the test plan for this revision. (Show Details)

I haven't checked what other strange things GCC does with -m[no-]abicalls so I'm calling this an initial implementation. The Linux Kernel is one example of a piece of software built with -mno-abicalls.

tomatabacu commandeered this revision.Jul 21 2014, 3:01 AM
tomatabacu added a reviewer: matheusalmeida.
tomatabacu added a subscriber: tomatabacu.

Commandeered to finish off the patch and make it ready for commit.

dsanders accepted this revision.Aug 7 2014, 8:23 AM
dsanders edited edge metadata.

LGTM with a nit.

We are still a long way from having proper -mno-abicalls support at this point but it's definitely a start.

lib/Target/Mips/MipsSubtarget.h
60

Is the 'bit' part of the name intentional? It doesn't look like it refers to any bit/bits.

This revision is now accepted and ready to land.Aug 7 2014, 8:23 AM
tomatabacu added inline comments.Aug 8 2014, 2:36 AM
lib/Target/Mips/MipsSubtarget.h
60

I'm not sure. That's how Matheus named it, so I left it like that.

dsanders added inline comments.Aug 8 2014, 2:38 AM
lib/Target/Mips/MipsSubtarget.h
60

In that case I'm going to drop the 'bit' suffix before I commit. Thanks.

dsanders closed this revision.Aug 8 2014, 3:10 AM
dsanders added a comment.EditedAug 8 2014, 3:16 AM

Committed in r215194.

So far you've mostly been finishing of Matheus's patches but I think you've pretty much got the hang of necessary submission quality, etc so I think you should ask Chris Lattner for commit access. You'll still be subject to pre-commit reviews but you'll be able to commit your own work once you've got a 'LGTM'.