This is an archive of the discontinued LLVM Phabricator instance.

[PATCH 6/6] [zorg] Don't use -DCMAKE_C_COMPILER*/-DCMAKE_CXX_COMPILER*
ClosedPublic

Authored by maxim-kuvyrkov on Jan 14 2018, 8:13 AM.

Details

Summary

... to override host compiler. Two-stage builds set CMAKE_C_COMPILER/
CMAKE_CXX_COMPILER in the environment, and it is error-prone to override
it in both environment and command-line. We should rely on host
rootfs to provide correct cc/c++ in $PATH.

Diff Detail

Repository
rL LLVM

Event Timeline

maxim-kuvyrkov created this revision.Jan 14 2018, 8:13 AM
rovka accepted this revision.Jan 15 2018, 6:07 AM

LGTM.

This revision is now accepted and ready to land.Jan 15 2018, 6:07 AM
This revision was automatically updated to reflect the committed changes.