Page MenuHomePhabricator

Documentation for loop unrolling pragmas.
ClosedPublic

Authored by meheff on Jun 18 2014, 2:22 PM.

Details

Summary

This patch extends the documentation for "#pragma clang loop" hints to include the unroll and unroll_count directives.

Diff Detail

Event Timeline

meheff updated this revision to Diff 10589.Jun 18 2014, 2:22 PM
meheff retitled this revision from to Documentation for loop unrolling pragmas..
meheff updated this object.
meheff edited the test plan for this revision. (Show Details)
meheff added a subscriber: Unknown Object (MLST).
eliben added inline comments.Jun 18 2014, 2:32 PM
docs/LanguageExtensions.rst
1796

Maybe s/loop count/loop trip count/ for clarify? There's another instance later on

1798

I find this sentence a bit confusing in the context of unroll pragmas which tell the unroller exactly how much we want to unroll. OTOH this sentence seems to be describing the unrolling heuristic?

meheff updated this revision to Diff 10643.Jun 19 2014, 9:51 AM

Thanks for the comments. Tyler, I incorporated your suggested rewrite of the unrolling paragraph. Hopefully it is clearer now.

I also split the vectorization/interleaving pragmas and the unrolling pragmas into separate sections.

Please take another look.

docs/LanguageExtensions.rst
1796

Rewrote this bit.

1798

Rewrote this bit.

eliben accepted this revision.Jun 19 2014, 9:55 AM
eliben edited edge metadata.

LGTM with a micro-nit: be consistent about one or two spaces after '.' -- I think one is fine and more globally consistent

This revision is now accepted and ready to land.Jun 19 2014, 9:55 AM
meheff updated this revision to Diff 10647.Jun 19 2014, 11:17 AM
meheff edited edge metadata.
In D4198#7, @eliben wrote:

LGTM with a micro-nit: be consistent about one or two spaces after '.' -- I think one is fine and more globally consistent

Done.

meheff closed this revision.Jun 19 2014, 12:58 PM