This is an archive of the discontinued LLVM Phabricator instance.

[test] Use full PATH lookup for tools
ClosedPublic

Authored by mgorny on Jan 4 2018, 5:58 AM.

Details

Summary

Use full PATH when looking up test tools rather than just llvm tools
directory. r320813 has added a lookup for 'lldb-test' which is part
of LLDB tools rather than LLVM, and therefore is not present
in llvm_tools_dir before LLDB is installed.

While technically we could introduce separate per-directory lookup
logic, there is no real reason not to use the PATH formed earlier here,
and this is what other tools are doing.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny created this revision.Jan 4 2018, 5:58 AM
labath accepted this revision.Jan 6 2018, 1:05 AM

lgtm, thanks.

This revision is now accepted and ready to land.Jan 6 2018, 1:05 AM
This revision was automatically updated to reflect the committed changes.