This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove side-effects from determineCalleeSaves
ClosedPublic

Authored by thegameg on Jan 3 2018, 8:58 AM.

Details

Summary

It should be possible for one to call (Target)FrameLowering::determineCalleeSaves multiple times. I don't think it should have side-effects as creating stack objects and setting global MachineFunctionInfo state as it is doing today (in other back-ends as well).

This moves the creation of stack objects from determineCalleeSaves to assignCalleeSavedSpillSlots in the X86 back-end.

Diff Detail

Event Timeline

thegameg created this revision.Jan 3 2018, 8:58 AM
rnk accepted this revision.Jan 5 2018, 3:20 PM

lgtm, thanks!

This revision is now accepted and ready to land.Jan 5 2018, 3:20 PM
This revision was automatically updated to reflect the committed changes.