This is an archive of the discontinued LLVM Phabricator instance.

[X86] Remove useless custom inserter for 64-bit TAILJMP and TCRETURN opcodes
ClosedPublic

Authored by craig.topper on Jan 2 2018, 11:04 AM.

Details

Summary

This custom inserter was added in r124272 at which time it added about bunch of Defs for Win64. In r150708, those defs were removed leaving only the "return BB". So I think this means the custom inserter is a NOP these days.

This patch removes the remaining code and stops tagging the instructions for custom insertion

Diff Detail

Repository
rL LLVM

Event Timeline

craig.topper created this revision.Jan 2 2018, 11:04 AM
RKSimon accepted this revision.Jan 3 2018, 8:35 AM

LGTM - it doesn't seem to affect the tailcall tests, which are all still present AFAICT

This revision is now accepted and ready to land.Jan 3 2018, 8:35 AM
This revision was automatically updated to reflect the committed changes.