Page MenuHomePhabricator

[x86][icelake][vaes]
ClosedPublic

Authored by coby on Dec 26 2017, 5:35 AM.

Details

Reviewers
craig.topper
Summary

added intrinsics support for vaes instructions, matching a similar work on the backend (D40078)

Diff Detail

Repository
rC Clang

Event Timeline

coby created this revision.Dec 26 2017, 5:35 AM
craig.topper added inline comments.Dec 26 2017, 9:09 AM
lib/Basic/Targets/X86.cpp
573

Shouldn't -aes imply -vaes?

coby added inline comments.Dec 26 2017, 9:47 AM
lib/Basic/Targets/X86.cpp
573

how come? perhaps i'm missing here something?
why would the first imply the latter?
following this road an atom z8XXX should be capable of supporting vaes, for example (where it lacks avx, for example, https://www.intel.com/content/www/us/en/processors/atom/atom-z8000-datasheet-vol-1.html)
also, in that sense, pclmul is implying vpclmulqdq

coby updated this revision to Diff 128185.Dec 26 2017, 12:21 PM

turning aes off forbids enabling vaes

This revision is now accepted and ready to land.Dec 26 2017, 1:57 PM
coby closed this revision.Dec 27 2017, 12:39 AM

closed by commit rC321474 (rL321474)