Page MenuHomePhabricator
Differential D41573

[x86][icelake][vpclmulqdq]
ClosedPublic
Actions

Authored by coby on Dec 25 2017, 3:48 AM.

Details

Reviewers
craig.topper
Commits
rC321480: [x86][icelake][vpclmulqdq]
rL321480: [x86][icelake][vpclmulqdq]
Summary

added intrinsics support for vpclmulqdq instructions, matching a similar work on the backend (D40101)

Diff Detail

Repository
rL LLVM

Event Timeline

coby created this revision.Dec 25 2017, 3:48 AM
Herald added a subscriber: mgorny. · View Herald TranscriptDec 25 2017, 3:48 AM
coby updated this revision to Diff 128139.Dec 25 2017, 6:04 AM

removing guards to allow better diags

craig.topper accepted this revision.Dec 25 2017, 12:12 PM

LGTM

This revision is now accepted and ready to land.Dec 25 2017, 12:12 PM
craig.topper requested changes to this revision.Dec 26 2017, 9:56 AM
craig.topper added inline comments.
lib/Basic/Targets/X86.cpp
577 ↗(On Diff #128139)

I think we should disable vpclmulqdq when pclmul is being disabled.

This revision now requires changes to proceed.Dec 26 2017, 9:56 AM
coby added inline comments.Dec 26 2017, 11:22 AM
lib/Basic/Targets/X86.cpp
577 ↗(On Diff #128139)

agreed

coby updated this revision to Diff 128183.Dec 26 2017, 12:04 PM

turning off pclmul forbids enabling vpclmulqdq

craig.topper accepted this revision.Dec 26 2017, 1:56 PM

LGTM

This revision is now accepted and ready to land.Dec 26 2017, 1:56 PM
Closed by commit rL321480: [x86][icelake][vpclmulqdq] (authored by coby). · Explain WhyDec 27 2017, 1:01 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
cfe/
trunk/
include/
clang/
Basic/
4 lines
Driver/
2 lines
lib/
Basic/
Targets/
1 line
17 lines
Headers/
1 line
4 lines
42 lines
test/
CodeGen/
4 lines
17 lines
Driver/
11 lines
Preprocessor/
2 lines
9 lines

Diff 128210

View Options

cfe/trunk/include/clang/Basic/BuiltinsX86.def

Loading...
View Options

cfe/trunk/include/clang/Driver/Options.td

Loading...
View Options

cfe/trunk/lib/Basic/Targets/X86.h

Loading...
View Options

cfe/trunk/lib/Basic/Targets/X86.cpp

Loading...
View Options

cfe/trunk/lib/Headers/CMakeLists.txt

Loading...
View Options

cfe/trunk/lib/Headers/immintrin.h

Loading...
View Options

cfe/trunk/lib/Headers/vpclmulqdqintrin.h

Loading...
View Options

cfe/trunk/test/CodeGen/attr-target-x86.c

Loading...
View Options

cfe/trunk/test/CodeGen/vpclmulqdq-builtins.c

Loading...
View Options

cfe/trunk/test/Driver/x86-target-features.c

Loading...
View Options

cfe/trunk/test/Preprocessor/predefined-arch-macros.c

Loading...
View Options

cfe/trunk/test/Preprocessor/x86_target_features.c

Loading...