Page MenuHomePhabricator

[Transforms] Support making mutable versions of new-format TBAA access tags
ClosedPublic

Authored by kosarev on Dec 24 2017, 6:52 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

kosarev created this revision.Dec 24 2017, 6:52 AM
hfinkel accepted this revision.Jan 15 2018, 11:23 AM

LGTM

lib/IR/MDBuilder.cpp
245 ↗(On Diff #128108)

// If Tag is already mutable then return it.

This revision is now accepted and ready to land.Jan 15 2018, 11:23 AM
This revision was automatically updated to reflect the committed changes.
apilipenko added inline comments.
llvm/trunk/lib/IR/MDBuilder.cpp
236

Typo getOperand(1) instead of getOperand(0). And the test doesn't catch this because in the test Base and Access types are always the same.

kosarev added inline comments.
llvm/trunk/lib/IR/MDBuilder.cpp
236

Prepared a fix in D42364. Thanks for catching!