This is an archive of the discontinued LLVM Phabricator instance.

[MC] - Disallow invalid section groups declarations.
ClosedPublic

Authored by grimar on Dec 24 2017, 12:19 AM.

Details

Summary

This fixes parseGroup() so that it always sets error condition on error.
Previously it was not done, because parseIdentifier looks never do that,
assuming that caller should do it if he wants to.

So previously cases from test were silently accepted and produced broken output.

Diff Detail

Event Timeline

grimar created this revision.Dec 24 2017, 12:19 AM
grimar edited the summary of this revision. (Show Details)Dec 24 2017, 8:51 AM
This revision was not accepted when it landed; it landed in state Needs Review.Dec 25 2017, 1:41 AM
This revision was automatically updated to reflect the committed changes.