This is an archive of the discontinued LLVM Phabricator instance.

[MSan,TSan] Add aligned new/delete interceptors.
ClosedPublic

Authored by alekseyshl on Dec 21 2017, 4:49 PM.

Details

Summary

Providing aligned new/delete implementations to match ASan.
Unlike ASan, MSan and TSan do not perform any additional checks
on overaligned memory, hence no sanitizer specific tests.

Diff Detail

Repository
rL LLVM

Event Timeline

alekseyshl created this revision.Dec 21 2017, 4:49 PM
Herald added subscribers: Restricted Project, kubamracek. · View Herald TranscriptDec 21 2017, 4:49 PM
eugenis added inline comments.Dec 21 2017, 5:06 PM
test/sanitizer_common/TestCases/Linux/new_delete_test.cc
9 ↗(On Diff #127970)

Please add failure mode tests.
Also, typo: satizier

alekseyshl marked an inline comment as done.Dec 21 2017, 5:10 PM
alekseyshl added inline comments.
test/sanitizer_common/TestCases/Linux/new_delete_test.cc
9 ↗(On Diff #127970)

ASan does have a failure test already, the rest do not have any failure modes yet, as they do not care about aligned/sized allocation mismatch.

eugenis accepted this revision.Dec 21 2017, 5:14 PM
eugenis added inline comments.
test/sanitizer_common/TestCases/Linux/new_delete_test.cc
9 ↗(On Diff #127970)

right.

This revision is now accepted and ready to land.Dec 21 2017, 5:14 PM
alekseyshl marked an inline comment as done.
  • Fix typo
This revision was automatically updated to reflect the committed changes.