Page MenuHomePhabricator

Add support for ObjectFormat to TargetSpecificAttr
ClosedPublic

Authored by erichkeane on Dec 15 2017, 10:51 AM.

Details

Summary

Looking through the code, I saw a FIXME on IFunc to switch it
to a target specific attribute. In looking through it, i saw that
the no-longer-appropriately-named TargetArch didn't support ObjectFormat
checking.

This patch changes the name of TargetArch to TargetSpecific
(since it checks much more than just Arch), makes "Arch" optional, adds
support for ObjectFormat, better documents the TargetSpecific type, and
changes IFunc over to a TargetSpecificAttr.

Diff Detail

Repository
rC Clang

Event Timeline

erichkeane created this revision.Dec 15 2017, 10:51 AM
aaron.ballman accepted this revision.Dec 20 2017, 10:19 AM

Aside from some minor nits, LGTM. Thanks!

include/clang/Basic/Attr.td
281

Extra space after "Formats"

utils/TableGen/ClangAttrEmitter.cpp
2665

Typo: GenerateTargetRequiresments

This revision is now accepted and ready to land.Dec 20 2017, 10:19 AM
This revision was automatically updated to reflect the committed changes.