Page MenuHomePhabricator

Fix `git-clang-format <commit1> <commit2>`.
AbandonedPublic

Authored by lodato on Dec 12 2017, 1:11 PM.

Details

Reviewers
djasper
klimek
Summary

This feature had never worked at all because the code incorrectly used <commit2> for both the "old" and "new", so the diff was always empty! Now we correctly use <commit1> where we should and it works fine.

Diff Detail

Event Timeline

lodato created this revision.Dec 12 2017, 1:11 PM

Actually the old code might have been working fine. Please hold off on reviewing.

Yeah, I was incorrect. The feature worked fine. I don't know what I was thinking.

lodato abandoned this revision.Dec 12 2017, 1:33 PM