Page MenuHomePhabricator

lodato (Mark Lodato)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 9 2016, 7:13 AM (188 w, 5 d)

Recent Activity

Dec 13 2017

lodato updated the diff for D41147: git-clang-format: Add new --staged option..

Update after change to D41145 that fixed len(commits) > 2 case.

Dec 13 2017, 11:00 AM
lodato added a comment to D41145: git-clang-format: refactor to support upcoming --staged flag.

Oops! Fixed. Thanks for catching this!

Dec 13 2017, 10:59 AM
lodato updated the diff for D41145: git-clang-format: refactor to support upcoming --staged flag.

Re-add check for len(commits) > 2.

Dec 13 2017, 10:58 AM

Dec 12 2017

lodato added a parent revision for D41147: git-clang-format: Add new --staged option.: D41145: git-clang-format: refactor to support upcoming --staged flag.
Dec 12 2017, 5:48 PM
lodato added a child revision for D41145: git-clang-format: refactor to support upcoming --staged flag: D41147: git-clang-format: Add new --staged option..
Dec 12 2017, 5:48 PM
lodato added a comment to D15465: [git-clang-format]: New option to perform formatting against staged changes only.

Oh, and I meant to start with: I'm so sorry for the extremely long delay. I was swamped with work before then I forgot about this. Please know that I appreciate your effort here and that I didn't mean to blow you off.

Dec 12 2017, 5:47 PM
lodato added a comment to D15465: [git-clang-format]: New option to perform formatting against staged changes only.

I think the simplest solution to those problems is to require --diff. An alternative is to write the changes directly to the index without touching the working directory, but that would require some flag because the behavior is unintuitive, and the implementation would be complicated enough to warrant its own patch.

Dec 12 2017, 5:43 PM
lodato created D41147: git-clang-format: Add new --staged option..
Dec 12 2017, 5:41 PM
lodato added a child revision for D41130: git-clang-format: cleanup: Use run() when possible.: D41145: git-clang-format: refactor to support upcoming --staged flag.
Dec 12 2017, 5:31 PM
lodato added a parent revision for D41145: git-clang-format: refactor to support upcoming --staged flag: D41130: git-clang-format: cleanup: Use run() when possible..
Dec 12 2017, 5:31 PM
lodato updated the summary of D41145: git-clang-format: refactor to support upcoming --staged flag.
Dec 12 2017, 5:31 PM
lodato created D41145: git-clang-format: refactor to support upcoming --staged flag.
Dec 12 2017, 5:16 PM
lodato abandoned D41129: Fix `git-clang-format <commit1> <commit2>`..
Dec 12 2017, 1:33 PM
lodato added a comment to D41129: Fix `git-clang-format <commit1> <commit2>`..

Yeah, I was incorrect. The feature worked fine. I don't know what I was thinking.

Dec 12 2017, 1:33 PM
lodato added a comment to D41129: Fix `git-clang-format <commit1> <commit2>`..

Actually the old code might have been working fine. Please hold off on reviewing.

Dec 12 2017, 1:32 PM
lodato updated the summary of D41130: git-clang-format: cleanup: Use run() when possible..
Dec 12 2017, 1:16 PM
lodato created D41130: git-clang-format: cleanup: Use run() when possible..
Dec 12 2017, 1:16 PM
lodato created D41129: Fix `git-clang-format <commit1> <commit2>`..
Dec 12 2017, 1:11 PM

Aug 30 2017

lodato added a comment to D15465: [git-clang-format]: New option to perform formatting against staged changes only.

Sorry, I have been very busy with other work so I haven't had a chance to follow along. (I don't work on LLVM team - I just contributed this script.)

Aug 30 2017, 6:53 AM

Dec 13 2016

lodato resigned from D27377: clang-format: Support the Java 8 'default' method modifier.

I know nothing about the C++ code. I only know the git-clang-format script.

Dec 13 2016, 11:22 AM

Nov 3 2016

lodato accepted D26287: clang-format: Use git-ls-tree to get file mode in diff mode.

Thanks for the fix!

Nov 3 2016, 4:54 PM

Oct 3 2016

lodato resigned from D25171: clang-format: Add two new formatting options.
Oct 3 2016, 7:10 AM

Sep 21 2016

lodato accepted D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Nice feature. Thanks for the patch!

Sep 21 2016, 2:15 PM · Restricted Project

Sep 20 2016

lodato added a comment to D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Could you add a note to the commit description to say that there is a backwards incompatibility: if a filename matches a branch name or other commit-ish, then git clang-format <commit> <file> will no longer work as expected; use git clang-format <commit> -- <file> instead.

Sep 20 2016, 7:50 PM · Restricted Project

Sep 19 2016

lodato added a comment to D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Sorry for the delay - I haven't had a chance to review. I'll be sure to review by tomorrow. Thanks for the updates!

Sep 19 2016, 2:12 PM · Restricted Project

Sep 12 2016

lodato added a comment to D24319: clang-format: Add an option to git-clang-format to diff between to commits.

Hi lhchavez,

Sep 12 2016, 3:46 PM · Restricted Project

Feb 9 2016

lodato added inline comments to D15465: [git-clang-format]: New option to perform formatting against staged changes only.
Feb 9 2016, 9:05 AM
lodato requested changes to D15465: [git-clang-format]: New option to perform formatting against staged changes only.

This does not work properly because it calls clang-format on the files in the working directory, even if --staged is given. To fix, you need to somehow pass in the version of the files in the index into clang-format. To do that, I think you'd want to pass in the blob via stdin and add -assume-filename=... to the command line.

Feb 9 2016, 8:58 AM