Page MenuHomePhabricator

[driver][darwin] Set the 'simulator' environment when it's specified in '-target'
ClosedPublic

Authored by arphaman on Dec 11 2017, 10:42 AM.

Details

Summary

This patch ensures that '-target' can be used to set the 'simulator' environment component in the target triple.

Diff Detail

Repository
rC Clang

Event Timeline

Other than the comment inline, LGTM.

lib/Driver/ToolChains/Darwin.cpp
1603–1605

Will be good to emit a warning for this. User should use -target with simulator or simulator deployment target.

steven_wu accepted this revision.Dec 15 2017, 4:12 PM
This revision is now accepted and ready to land.Dec 15 2017, 4:12 PM
bob.wilson accepted this revision.Dec 15 2017, 8:50 PM

LGTM

lib/Driver/ToolChains/Darwin.cpp
1603–1605

Can we hold off on the warning and try to add that separately in the future? It would be good to first find out how often this code is being used. If there are a lot of uses, we may need to try to get people to stop relying on it before we add the warning. (I'm concerned about -Werror breaking builds with this.)

This revision was automatically updated to reflect the committed changes.