Remove `lnt update` command.

[fhahn]

Summary

lnt update is broken because of a missing import and there should be
no need for it anymore, because databases are upgraded when starting
the server. It is not mentioned in the docs.

[MatzeB]

I wonder: Is this functionality good for anything nowadays? LNT always performs an upgrade when the server is started, so I don't see why one would want to do it manually. So the better fix may be to just remove the whole function :)

When not removing it, it would be nice to add at least a small sanity test to tests/lnttool.

[fhahn]

I used

In D40704#942439, @MatzeB wrote:

I wonder: Is this functionality good for anything nowadays? LNT always performs an upgrade when the server is started, so I don't see why one would want to do it manually. So the better fix may be to just remove the whole function :)

I just used it to initialize the tables in multiple postgresql databases, as there is no createdb command anymore (I am running a LNT instance with multiple databases). But maybe there is a better way to do that? AFAIK lnt create only initializes a single database, and the empty databases I added additionally where not recognized until I ran lnt update on them.

[MatzeB]

In D40704#942454, @fhahn wrote:

I used

In D40704#942439, @MatzeB wrote:

I wonder: Is this functionality good for anything nowadays? LNT always performs an upgrade when the server is started, so I don't see why one would want to do it manually. So the better fix may be to just remove the whole function :)

I just used it to initialize the tables in multiple postgresql databases, as there is no createdb command anymore (I am running a LNT instance with multiple databases). But maybe there is a better way to do that? AFAIK lnt create only initializes a single database, and the empty databases I added additionally where not recognized until I ran lnt update on them.

I would have expected that you can just setup the postgresql connection in lnt.cfg and the tables get created on first server startup. Though admittedly I haven't setup any production servers, so I may be missing something...

[fhahn]

In D40704#942478, @MatzeB wrote:

I would have expected that you can just setup the postgresql connection in lnt.cfg and the tables get created on first server startup. Though admittedly I haven't setup any production servers, so I may be missing something...

Ok I tried it again and indeed the databases are created when starting the server. Should I remove update?

[MatzeB]

In D40704#942891, @fhahn wrote:

In D40704#942478, @MatzeB wrote:

I would have expected that you can just setup the postgresql connection in lnt.cfg and the tables get created on first server startup. Though admittedly I haven't setup any production servers, so I may be missing something...

Ok I tried it again and indeed the databases are created when starting the server. Should I remove update?

That would be great.

[fhahn]

Remove lnt update instead of fixing it.

[MatzeB]

LGTM, thanks!

lnt/trunk/lnt/lnttool/main.py

for submitted_file in results:
         if verbose:
             lnt.util.ImportData.print_report_result(
                 submitted_file, sys.stdout, sys.stderr, True)
         _print_result_url(submitted_file, verbose)
     if len(files) != len(results):
         sys.exit(1)
 
 
[e-mail]("update")
[e-mail]("db_path")
[e-mail]("--show-sql", is_flag=True, help="show all SQL queries")
-def action_update(db_path, show_sql):
-    """create and or auto-update the given database"""
-    init_logger(logging.INFO, show_sql=show_sql, stream=sys.stderr)
-
-    # Update the database.
-    lnt.server.db.migrate.update_path(db_path)
-
-
 @click.command("send-daily-report")
 @click.argument("instance_path", type=click.UNPROCESSED)
 @click.argument("address")
 @click.option("--database", default="default", show_default=True,
               help="database to use")
 @click.option("--testsuite", default="nts", show_default=True,
               help="testsuite to use")
 @click.option("--host", default="localhost", show_default=True,

 main.add_command(action_import)
 main.add_command(action_importreport)
 main.add_command(action_profile)
 main.add_command(action_runserver)
 main.add_command(action_send_daily_report)
 main.add_command(action_send_run_comparison)
 main.add_command(action_showtests)
 main.add_command(action_submit)
-main.add_command(action_update)
 main.add_command(action_updatedb)
 main.add_command(action_view_comparison)
 main.add_command(group_admin)
 main.add_command(group_runtest)
 
 
 if __name__ == '__main__':
     main()