Handle binding in --wrap

[• rafael]

Summary

I am checking what should and should not be copied in copyFrom.

Copying the binding seems reasonable and matches the bfd behavior.

[ruiu]

LGTM

[• espindola]

r319196

ELF/Symbols.cpp

 
 // Overwrites all attributes with Other's so that this symbol becomes
 // an alias to Other. This is useful for handling some options such as
 // --wrap.
 void Symbol::copyFrom(Symbol *Other) {
   Symbol Sym = *this;
   memcpy(this, Other, sizeof(SymbolUnion));
 
-  Binding = Sym.Binding;
   VersionId = Sym.VersionId;
   Visibility = Sym.Visibility;
   IsUsedInRegularObj = Sym.IsUsedInRegularObj;
   ExportDynamic = Sym.ExportDynamic;
   CanInline = Sym.CanInline;
   Traced = Sym.Traced;
   InVersionScript = Sym.InVersionScript;
 }

test/ELF/Inputs/wrap.s

-.globl foo, __wrap_foo, __real_foo
+.global foo
+.weak __wrap_foo
+.global __real_foo
 foo = 0x11000
 __wrap_foo = 0x11010
 __real_foo = 0x11020

test/ELF/wrap.s

 // CHECK: _start:
 // CHECK-NEXT: movl $0x11010, %edx
 // CHECK-NEXT: movl $0x11010, %edx
 // CHECK-NEXT: movl $0x11000, %edx
 
 // RUN: llvm-readobj -t %t3 | FileCheck -check-prefix=SYM %s
 // SYM:      Name: foo
 // SYM-NEXT: Value: 0x11000
+// SYM-NEXT: Size:
+// SYM-NEXT: Binding: Global
 // SYM:      Name: __wrap_foo
 // SYM-NEXT: Value: 0x11010
+// SYM-NEXT: Size:
+// SYM-NEXT: Binding: Weak
 // SYM:      Name: __real_foo
 // SYM-NEXT: Value: 0x11020
+// SYM-NEXT: Size:
+// SYM-NEXT: Binding: Global
 
 .global _start
 _start:
   movl $foo, %edx
   movl $__wrap_foo, %edx
   movl $__real_foo, %edx