[FuzzMutate] Pick correct index for the insertvalue instruction

[igor-laevsky]

Summary

This fixes simple typo in the insertvalue descriptor. We need to pick index of the correctly typed element.

[bogner]

LGTM

lib/FuzzMutate/Operations.cpp

static SourcePred matchScalarInAggregate() {
   };
   return {Pred, Make};
 }
 
 static SourcePred validInsertValueIndex() {
   auto Pred = [](ArrayRef<Value *> Cur, const Value *V) {
     auto *CTy = cast<CompositeType>(Cur[0]->getType());
     if (auto *CI = dyn_cast<ConstantInt>(V))
-      if (CI->getBitWidth() == 32)
-        if (CTy->getTypeAtIndex(CI->getZExtValue()) == V->getType())
-          return true;
+      if (CI->getBitWidth() == 32 &&
+          CTy->getTypeAtIndex(CI->getZExtValue()) == Cur[1]->getType())
     return false;
   };
   auto Make = [](ArrayRef<Value *> Cur, ArrayRef<Type *> Ts) {
     std::vector<Constant *> Result;
     auto *Int32Ty = Type::getInt32Ty(Cur[0]->getContext());
     auto *CTy = cast<CompositeType>(Cur[0]->getType());
     for (int I = 0, E = getAggregateNumElements(CTy); I < E; ++I)
       if (CTy->getTypeAtIndex(I) == Cur[1]->getType())

unittests/FuzzMutate/RandomIRBuilderTest.cpp

TEST(RandomIRBuilderTest, ShuffleVectorIncorrectOperands) {
   // Create new source. Check that it always matches with the descriptor.
   // Run some iterations to account for random decisions.
   for (int i = 0; i < 10; ++i) {
     Value *LastSrc = IB.newSource(BB, Insts, Srcs, Descr.SourcePreds[2]);
     ASSERT_TRUE(Descr.SourcePreds[2].matches(Srcs, LastSrc));
   }
 }
 
+TEST(RandomIRBuilderTest, InsertValueIndexes) {
+  // Check that we will generate correct indexes for the insertvalue operation
+
+  LLVMContext Ctx;
+  const char *Source =
+      "%T = type {i8, i32, i64}\n"
+      "define void @test() {\n"
+      "  %A = alloca %T\n"
+      "  %L = load %T, %T* %A"
+      "  ret void\n"
+      "}";
+  auto M = parseAssembly(Source, Ctx);
+
+  fuzzerop::OpDescriptor IVDescr = fuzzerop::insertValueDescriptor(1);
+
+  std::vector<Type *> Types =
+      {Type::getInt8Ty(Ctx), Type::getInt32Ty(Ctx), Type::getInt64Ty(Ctx)};
+  RandomIRBuilder IB(Seed, Types);
+
+  // Get first basic block of the first function
+  Function &F = *M->begin();
+  BasicBlock &BB = *F.begin();
+
+  // Pick first source
+  SmallVector<Value *, 2> Srcs(2);
+  ASSERT_TRUE(IVDescr.SourcePreds[0].matches(Srcs, &*std::next(BB.begin())));
+  Srcs[0] = &*BBIt;
+
+  // Generate constants for each of the types and check that we pick correct
+  // index for the given type
+  for (auto *T: Types) {
+    // Loop to account for possible random decisions
+    for (int i = 0; i < 10; ++i) {
+      // Create value we want to insert. Only it's type matters.
+      Srcs[1] = ConstantInt::get(T, 5);
+
+      // Try to pick correct index
+      Value *Src = IB.findOrCreateSource(
+          BB, &*BB.begin(), Srcs, IVDescr.SourcePreds[2]);
+      ASSERT_TRUE(IVDescr.SourcePreds[2].matches(Srcs, Src));
+    }
+  }
+}
+
 }