[libcxx] [test] Resolve C1XX warning in new vector<bool>::size tests caused by assert(true)

[BillyONeal]

Summary

In a17cd7c641c34b6c4bd4845a4d4fb590cb6c238c Marshall added assert(true) to the vector<bool>::size tests, which break on C1XX:
D:\Contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(62): error C2220: warning treated as error - no 'object' file generated
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(33) : warning C6326: Potential comparison of a constant with another constant.
d:\contest\gl0qojfu.5pe\src\qa\vc\libs\libcxx\upstream\test\std\containers\sequences\vector.bool\size.pass.cpp(52) : warning C6326: Potential comparison of a constant with another constant.

The corresponding test for vector::size asserts assert(c.size() == 3);, so I changed it to do that here.

[BillyONeal]

Committed r318812

[mclow.lists]

D'Oh - that was a paste that went wrong.
You are correct that assert(c.size() == 3) is correct.

However, what I was *trying* to fix were the lines before.
Pushing a 3 into a vector<bool> is not the best idea L#34 and L#53 should both read c.push_back(true);

test/std/containers/sequences/vector.bool/size.pass.cpp

int main()
     C c;
     ASSERT_NOEXCEPT(c.size());
     assert(c.size() == 0);
     c.push_back(false);
     assert(c.size() == 1);
     c.push_back(true);
     assert(c.size() == 2);
     c.push_back(C::value_type(3));
-    assert(true);
+    assert(c.size() == 3);
     c.erase(c.begin());
     assert(c.size() == 2);
     c.erase(c.begin());
     assert(c.size() == 1);
     c.erase(c.begin());
     assert(c.size() == 0);
     }
 #if TEST_STD_VER >= 11
     {
     typedef std::vector<bool, min_allocator<bool>> C;
     C c;
     ASSERT_NOEXCEPT(c.size());
     assert(c.size() == 0);
     c.push_back(false);
     assert(c.size() == 1);
     c.push_back(true);
     assert(c.size() == 2);
     c.push_back(C::value_type(3));
-    assert(true);
+    assert(c.size() == 3);
     c.erase(c.begin());
     assert(c.size() == 2);
     c.erase(c.begin());
     assert(c.size() == 1);
     c.erase(c.begin());
     assert(c.size() == 0);
     }
 #endif
 }