This is an archive of the discontinued LLVM Phabricator instance.

[CMake] Use LIST_SEPARATOR rather than escaping in ExternalProject_Add
ClosedPublic

Authored by phosek on Nov 20 2017, 9:02 AM.

Details

Summary

Escaping ; in list arguments passed to ExternalProject_Add doesn't seem
to be working in newer versions of CMake (see
https://public.kitware.com/Bug/view.php?id=16137 for more details). Use
a custom LIST_SEPARATOR instead which is the officially supported way.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Nov 20 2017, 9:02 AM
phosek updated this revision to Diff 123640.Nov 20 2017, 12:59 PM
phosek updated this revision to Diff 123710.Nov 20 2017, 8:26 PM

Can you please take a look at this one as well (this one is Clang, the other one was LLVM)?

beanz accepted this revision.Nov 27 2017, 11:15 AM

LGTM!

This revision is now accepted and ready to land.Nov 27 2017, 11:15 AM
This revision was automatically updated to reflect the committed changes.