This is an archive of the discontinued LLVM Phabricator instance.

[XRay][test-suite] Upgrade Google benchmark library
ClosedPublic

Authored by eizan on Nov 16 2017, 3:53 PM.

Details

Summary

This change allows us to use an updated idiom for defining microbenchmarks.

Version being upgraded from 1.2.0 to 1.3.0.

Diff Detail

Repository
rL LLVM

Event Timeline

eizan created this revision.Nov 16 2017, 3:53 PM
dberris accepted this revision.Nov 16 2017, 4:06 PM

LGTM

This revision is now accepted and ready to land.Nov 16 2017, 4:06 PM
eizan edited the summary of this revision. (Show Details)Nov 16 2017, 4:08 PM
This revision was automatically updated to reflect the committed changes.

Hmm, no NetBSD support. Investigating and I will submit a patch upstream.

Hmm, no NetBSD support. Investigating and I will submit a patch upstream.

Huh. @krytarowski -- did this used to work (NetBSD) in 1.2.0? Or do you mean XRay tracing in particular?

Hmm, no NetBSD support. Investigating and I will submit a patch upstream.

Huh. @krytarowski -- did this used to work (NetBSD) in 1.2.0? Or do you mean XRay tracing in particular?

Feel free to backport to LLVM: "Add NetBSD support"
https://github.com/google/benchmark/pull/482

This patch makes benchmark work more correct.

test-suite/trunk/MicroBenchmarks/libs/benchmark-1.2.0/tools/gbench/Inputs/test1_run2.json