This is an archive of the discontinued LLVM Phabricator instance.

[CMake][runtimes] Don't passthrough prefixes for non-default targets
ClosedPublic

Authored by phosek on Nov 13 2017, 4:36 PM.

Details

Summary

The passthrough is useful for setting up the options for the default
build, but we already have a different mechanism to pass CMake flags
to builds for builtins and runtimes targets so this is not really
needed there. Furthermore, when the flags are set for the default
build, with the prefix passthrough set we have to explicitly override
all options in other targets which can be cumbersome.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek created this revision.Nov 13 2017, 4:36 PM
beanz accepted this revision.Nov 17 2017, 9:20 AM

LGTM

This revision is now accepted and ready to land.Nov 17 2017, 9:20 AM
phosek updated this revision to Diff 123442.Nov 17 2017, 3:51 PM
This revision was automatically updated to reflect the committed changes.