This is an archive of the discontinued LLVM Phabricator instance.

[test-suite] [CUDA] Delete nexttoward and nextafter CUDA tests, because these functions have no implementations.
AbandonedPublic

Authored by jlebar on Nov 6 2017, 3:04 PM.

Details

Reviewers
tra
Summary

These functions never actually worked -- if you called them, you'd get a
ptxas error when llvm tried to make a libcall to e.g. nexttowardf.

This test only compiled because the calls were DCE'ed. Sadly my
laziness in not checking the return value of these functions resulted in
this long-standing bug.

On the upside, we check the return values of all other math functions,
so this bug is limited to nexttoward and nextafter.

Event Timeline

jlebar created this revision.Nov 6 2017, 3:04 PM
jlebar abandoned this revision.Nov 8 2017, 3:18 PM

Abandoning because it looks like we *can* implement nexttoward in CUDA, see D39703. Will send a different patch.